-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOK-410: all time share #359
Conversation
93b2f5a
to
552bfcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8766ed7
to
7f0a332
Compare
552bfcc
to
191cb10
Compare
7f0a332
to
ec28fd6
Compare
191cb10
to
7c25052
Compare
ec28fd6
to
bfabaef
Compare
e7666eb
to
d36db71
Compare
2cf0de1
to
0d4951e
Compare
d36db71
to
7483cb1
Compare
7483cb1
to
8b1263d
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if (!rewardsPerToken[rif.address] || !gaugeRewardsPerToken[rif.address]) { | ||
return ( | ||
<MetricsCardWithSpinner isLoading={isLoading} borderless> | ||
<MetricsCardTitle title="All time share" data-testid="AllTimeShare" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franciscotobar Should we enclose it in a div as we do below?
What
Link