Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOK-410: all time share #359

Merged
merged 1 commit into from
Nov 13, 2024
Merged

TOK-410: all time share #359

merged 1 commit into from
Nov 13, 2024

Conversation

franciscotobar
Copy link
Contributor

@franciscotobar franciscotobar commented Nov 11, 2024

What

  • All time share

Link

Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciscotobar franciscotobar force-pushed the TOK-409/all-time-rewards branch from 8766ed7 to 7f0a332 Compare November 11, 2024 18:36
@franciscotobar franciscotobar force-pushed the TOK-409/all-time-rewards branch from 7f0a332 to ec28fd6 Compare November 12, 2024 01:09
@jurajpiar jurajpiar force-pushed the TOK-409/all-time-rewards branch from ec28fd6 to bfabaef Compare November 12, 2024 09:46
@jurajpiar jurajpiar force-pushed the TOK-410/all-time-share branch 2 times, most recently from e7666eb to d36db71 Compare November 12, 2024 11:40
@jurajpiar
Copy link
Contributor

Screenshot 2024-11-12 at 11 39 26 Do you plan on centring the text it in this PR?

@franciscotobar franciscotobar force-pushed the TOK-409/all-time-rewards branch 3 times, most recently from 2cf0de1 to 0d4951e Compare November 12, 2024 12:45
@antomor antomor changed the title feat(cr_v2): all time share TOK-410: all time share Nov 12, 2024
@franciscotobar franciscotobar changed the base branch from TOK-409/all-time-rewards to develop November 12, 2024 16:01
Copy link

github-actions bot commented Nov 12, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if (!rewardsPerToken[rif.address] || !gaugeRewardsPerToken[rif.address]) {
return (
<MetricsCardWithSpinner isLoading={isLoading} borderless>
<MetricsCardTitle title="All time share" data-testid="AllTimeShare" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscotobar Should we enclose it in a div as we do below?

@antomor antomor merged commit 10a2a33 into develop Nov 13, 2024
6 checks passed
@antomor antomor deleted the TOK-410/all-time-share branch November 13, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants