Updated .env to have new NFT address. #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated CommunitiesSection.tsx to properly display the NFTs. Updated [address].tsx to have better error handling when nftInfo is not set.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -60,7 +60,9 @@ | |||
| const { stRifBalance } = useStRif() | |||
|
|
|||
| const nftInfo = communitiesMapByContract[nftAddress || ''] | |||
|
|
|||
| if (nftInfo === undefined) { | |||
| console.warn(`The current NFT address is not registered: ${nftAddress} - Please check the config.`) | |||
Check warning
Code scanning / CodeQL
Log injection Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 months ago
To fix the log injection issue, we need to sanitize the nftAddress before logging it. Specifically, we should remove any newline characters from the nftAddress to prevent log injection. This can be done using String.prototype.replace to remove newline characters.
Suggested changeset
1
src/pages/communities/nft/[address].tsx
| @@ -63,3 +63,4 @@ | ||
| if (nftInfo === undefined) { | ||
| console.warn(`The current NFT address is not registered: ${nftAddress} - Please check the config.`) | ||
| const sanitizedNftAddress = nftAddress?.replace(/\n|\r/g, "") | ||
| console.warn(`The current NFT address is not registered: ${sanitizedNftAddress} - Please check the config.`) | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
shenshin
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CommunitiesSection.tsx to properly display the NFTs. Updated [address].tsx to have better error handling when nftInfo is not set.