Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make left bottom info in left side bar fixed and sticky #297

Merged
merged 9 commits into from
Nov 6, 2024

Conversation

LordCheta
Copy link
Contributor

@LordCheta LordCheta commented Oct 29, 2024

This PR addresses this jira ticket

Previous Render
Screenshot 2024-10-29 at 9 03 37 AM

Current Render
Screenshot 2024-10-29 at 9 04 12 AM

Render for smaller screens
Screenshot 2024-10-29 at 4 36 34 PM

@LordCheta LordCheta requested a review from Freshenext October 29, 2024 08:08
Copy link
Collaborator

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, kinda, but also has this issue if the screen is too small:

Screenshot 2024-10-29 at 1 10 33 PM

Copy link
Contributor

@Freshenext Freshenext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and let them decide if they want it to stick.

@Freshenext Freshenext dismissed jessgusclark’s stale review October 29, 2024 16:08

Let's merge and let them see and decide if they want it sticky.

@jessgusclark
Copy link
Collaborator

This will wait for the next release.

@jessgusclark jessgusclark merged commit 864e91f into develop Nov 6, 2024
5 checks passed
@jessgusclark jessgusclark deleted the fix/DAO_769 branch November 6, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants