TOK-514: disabled if builder not operational (#428)

* refactor: disabled if builder not operational * refactor: pr comments
RootstockCollective · Dec 5, 2024 · 97b525e · 97b525e
1 parent 9e46efc
commit 97b525e
Show file tree

Hide file tree

Showing 5 changed files with 44 additions and 19 deletions.
diff --git a/src/app/collective-rewards/settings/builder/BuilderRewardsSettingsForm.tsx b/src/app/collective-rewards/settings/builder/BuilderRewardsSettingsForm.tsx
@@ -7,8 +7,9 @@ import { FC, useEffect, useState } from 'react'
 import { useForm } from 'react-hook-form'
 import { GoRocket } from 'react-icons/go'
 import { z } from 'zod'
-import { percentageToWei } from '../utils'
+import { percentageToWei } from '@/app/collective-rewards/settings/utils'
 import { useBuilderSettingsContext } from './context'
+import { Popover } from '@/components/Popover'
 
 const formSchema = z.object({
   reward: z
@@ -42,6 +43,7 @@ export const BuilderRewardsSettingsForm: FC = () => {
   const {
     current: { refetch, isLoading: isCurrentRewardsLoading },
     update: { isSuccess, setNewReward, isPending },
+    isBuilderOperational,
   } = useBuilderSettingsContext()
 
   const form = useForm<z.infer<typeof formSchema>>({
@@ -84,22 +86,41 @@ export const BuilderRewardsSettingsForm: FC = () => {
                 {isCurrentRewardsLoading ? (
                   <LoadingSpinner />
                 ) : (
-                  <FormInput placeholder="0 ... 100 %" inputMode="decimal" {...field} />
+                  <FormInput
+                    placeholder="0 ... 100 %"
+                    inputMode="decimal"
+                    {...field}
+                    disabled={!isBuilderOperational}
+                  />
                 )}
               </FormControl>
               <FormMessage />
             </FormItem>
           )}
         ></FormField>
         <div className="flex flex-row justify-start gap-4">
-          <Button
-            startIcon={<GoRocket />}
-            disabled={!isDirty || !isValid}
-            buttonProps={{ type: 'submit' }}
-            loading={isPending}
+          <Popover
+            content={
+              <div className="text-[12px] font-bold mb-1">
+                <p data-testid="adjustBackerRewardPctTooltip">
+                  You need to be operational to adjust your backer reward %
+                </p>
+              </div>
+            }
+            size="small"
+            position="top"
+            trigger="hover"
+            disabled={isBuilderOperational}
           >
-            Save changes
-          </Button>
+            <Button
+              startIcon={<GoRocket />}
+              disabled={!isDirty || !isValid || !isBuilderOperational}
+              buttonProps={{ type: 'submit' }}
+              loading={isPending}
+            >
+              Save changes
+            </Button>
+          </Popover>
           <Button
             variant="secondary"
             onClick={() => {

diff --git a/src/app/collective-rewards/settings/builder/context/BuilderSettingsContext.tsx b/src/app/collective-rewards/settings/builder/context/BuilderSettingsContext.tsx
@@ -8,11 +8,14 @@ import {
 import { createContext, FC, ReactNode, useContext } from 'react'
 import { Address } from 'viem'
 import { useAccount } from 'wagmi'
+import { useBuilderContext } from '@/app/collective-rewards/user'
+import { isBuilderOperational } from '@/app/collective-rewards/utils'
 
 type BackerRewardsPercentageContext = {
   update: SetBackerRewardsForBuilder
   current: BackerRewardResponse
   rewardPercentageToApply: RewardPercentageToApply
+  isBuilderOperational: boolean
 }
 
 const BuilderSettingsContext = createContext<BackerRewardsPercentageContext>(
@@ -22,15 +25,19 @@ const BuilderSettingsContext = createContext<BackerRewardsPercentageContext>(
 export const useBuilderSettingsContext = () => useContext(BuilderSettingsContext)
 
 export const BuilderSettingsProvider: FC<{ children: ReactNode }> = ({ children }) => {
+  const { getBuilderByAddress } = useBuilderContext()
   const { address } = useAccount()
   const current = useGetBackerRewardsForBuilder(address as Address)
   const update = useSetBackerRewardsForBuilder()
   const rewardPercentageToApply = useGetRewardPercentageToApply(address as Address)
+  const builder = getBuilderByAddress(address as Address)
+  const isOperational = builder ? isBuilderOperational(builder.stateFlags) : false
 
   const contextValue: BackerRewardsPercentageContext = {
     update,
     current,
     rewardPercentageToApply,
+    isBuilderOperational: isOperational,
   }
 
   return <BuilderSettingsContext.Provider value={contextValue}>{children}</BuilderSettingsContext.Provider>

diff --git a/src/app/collective-rewards/settings/builder/index.ts b/src/app/collective-rewards/settings/builder/index.ts
@@ -1,3 +1,5 @@
 export * from './BuilderRewardsSettingsMetrics'
 export * from './BuilderRewardsSettingsForm'
 export * from './BuilderSettings'
+export * from './context'
+export * from './hooks'
diff --git a/src/app/collective-rewards/shared/components/Table/TableCells.tsx b/src/app/collective-rewards/shared/components/Table/TableCells.tsx
@@ -208,17 +208,12 @@ export const ActionCell: FC<ActionCellProps> = ({ tableHeader: { className }, bu
     [selections, builderAddress, isPreallocated],
   )
 
-  const isBuilderOperational = useMemo(() => {
+  const isOperational = useMemo(() => {
     if (!builder) {
       console.log('Builder not found in selection') // TODO: handle this case better
       return
     }
-    return (
-      builder.stateFlags &&
-      builder.stateFlags.kycApproved &&
-      builder.stateFlags.communityApproved &&
-      !builder.stateFlags.paused
-    )
+    return isBuilderOperational(builder.stateFlags)
   }, [builder])
 
   const selectBuilder = () => {
@@ -229,7 +224,7 @@ export const ActionCell: FC<ActionCellProps> = ({ tableHeader: { className }, bu
     <TableCell className={cn(className, 'border-solid align-center')}>
       <Button
         variant={isSelected ? 'white' : 'secondary'}
-        disabled={!isBuilderOperational || isPreallocated}
+        disabled={!isOperational || isPreallocated}
         onClick={selectBuilder}
         className="white text-center"
       >

diff --git a/src/app/collective-rewards/utils/getMostAdvancedProposal.ts b/src/app/collective-rewards/utils/getMostAdvancedProposal.ts
@@ -4,8 +4,8 @@ import { ProposalState } from '@/shared/types'
 
 const inactiveProposalsStates = [ProposalState.Canceled, ProposalState.Defeated, ProposalState.Expired]
 const isActive = (state: ProposalState) => !inactiveProposalsStates.includes(state)
-const isBuilderActive = (status?: BuilderStateFlags) =>
-  !status || status.activated || status.communityApproved
+const isBuilderActive = (stateFlags?: BuilderStateFlags) =>
+  !stateFlags || stateFlags.activated || stateFlags.communityApproved
 
 export const getMostAdvancedProposal = (
   proposalsEvent: CreateBuilderProposalEventLog[],