Merge pull request #122 from dingjules/master

fix return types for i18next.t when returnObjects: true
Romanchuk · Jun 3, 2024 · b409feb · b409feb
2 parents c940b05 + 829b8ae
commit b409feb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/libs/angular-i18next/src/lib/ITranslationService.ts b/libs/angular-i18next/src/lib/ITranslationService.ts
@@ -26,15 +26,15 @@ export type ITranslationService = Modify<Partial<i18n.i18n>, {
 
   init(options: i18n.InitOptions): Promise<I18NextLoadResult>;
 
-  t(
+  t<Options extends ITranslationOptions>(
     key: string | string[],
-    options?: ITranslationOptions,
-  ): i18n.TFunctionReturn<i18n.Namespace, string | string[], ITranslationOptions>;
-  t(
+    options?: Options,
+  ): i18n.TFunctionReturn<i18n.Namespace, string | string[], Options>;
+  t<Options extends ITranslationOptions>(
     key: string | string[],
     defaultValue: string,
-    options?: ITranslationOptions
-  ): i18n.TFunctionReturn<i18n.Namespace, string | string[], ITranslationOptions>;
+    options?: Options
+  ): i18n.TFunctionReturn<i18n.Namespace, string | string[], Options>;
 
   format: i18n.FormatFunction;
 

diff --git a/libs/angular-i18next/src/tests/service/I18NextService.spec.ts b/libs/angular-i18next/src/tests/service/I18NextService.spec.ts
@@ -76,6 +76,14 @@ describe('I18nService', () => {
     });
   });
 
+  it('should be able to return different types while setting returnObjects: true (no typechecking errors)', () => {
+    const service: ITranslationService = TestBed.inject(I18NEXT_SERVICE);
+    service.t('some.string') as string;
+    service.t('some.string', {
+      returnObjects: true
+    }) as string[];
+  });
+
   /*
   // does not work because language=cimode ignores default value
   // setting language to anything other than 'cimode' breaks the rest of the tests