Changed random keyrings logic #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was this closed? This seems like a reasonable change to me. |
At first I was considering making this a separate keyring setting, but yeah, on second thought, that's probably not necessary. |
fenhl
pushed a commit
to fenhl/OoT-Randomizer
that referenced
this pull request
Apr 18, 2023
Add more conditionally foolish items
|
@AndrewLeving Would you be interested in PRing this upstream at OoTRandomizer/OoT-Randomizer? I can't guarantee that it will be accepted, but I think it makes more sense there since it's not related to anything exclusive to Dev-R. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed random keyrings to roll 50/50 per dungeon similar to how random MQ dungeons are decided.
This makes it more likely for there to be a mix of keyring and non-keyring dungeons, and less likely for there to be either all or no keyrings.