Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dragon Age RPG.htmln. New Feature & Bugfix #13501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Didenhyves
Copy link

Modified the char_name attribute to character_name, so the sheet name will now be synchronised.

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Feature : The sheet's name will now have the same name as the character. Updated automatically thanks to the "attr_character_name" avalaible on Roll20;

Bugfix : Fixed a bug where the repeatable ranged weapon wouldn't display the correct name due to a bad attribute calling in the roll button. (Was @{Weapon_Name} instead of @{ranged_Weapon_Name}

Modified the char_name attribute to character_name, so the sheet name will now be synchronised. 
Corrected a bug where the repeatable ranged weapon wouldn't display the correct name due to a bad attribute calling in the roll button.
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@kfroll20
Copy link
Contributor

Hi @Didenhyves!

Thank you for contributing to this sheet. Since you are changing an attribute name, this would mean all existing sheets with that data will be lost with this merge. While the new attribute you are using is a Roll20 attribute, we would still like to preserve the existing data for users who wish to keep their sheet names as is. When changing attribute names, sheet workers should be used to transfer data to preserve all existing data. Once this is handled, we can get this merged for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants