Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binding on MiddleClick to remove file being tailed #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add binding on MiddleClick to remove file being tailed #153

wants to merge 2 commits into from

Conversation

rc201612
Copy link

@rc201612 rc201612 commented Jul 6, 2016

Quite a trivial change, but I feel it adds something. Added an input binding on Middle Click to close / remove file being tailed.

@RolandPheasant
Copy link
Owner

The command you hooked into will remove the selected filter not the file.

To remove the file the bindings / command would need to be hooked into WindowViewModel / MainWindow and the actual file would have to be removed from the observable collection (Views)

@rc201612
Copy link
Author

rc201612 commented Jul 6, 2016

Apologies, it was meant to say filter. I don't know why I wrote file..

Will do similar for removing file.

@RolandPheasant
Copy link
Owner

I think the idea of a short cut to remove the filter is good. However I wonder whether there is a more explicit short cut option?

@rc201612
Copy link
Author

rc201612 commented Jan 7, 2017

I think a shortcut would definitely be useful. What shortcut do you have in mind?

I was thinking that Ctrl+ W could be used to close the file, and Middle-Clicking on a filter could remove the filter. It's a bit easier than trying to locate the small X and pressing it.

@maynardflies
Copy link

I think middle click to remove the file is even more important as that's a pretty common shortcut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants