BUG: Correctly update atmospheric conditions after changing date and location

[WilliamArmst]

Pull request type

Bugfix

Checklist

• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest tests -m slow --runslow) have passed locally
• CHANGELOG.md has been updated (if relevant)

Current behavior

If the environment date is updated after setting the atmospheric model, the function call to update the model to that date did not pass self.atmospheric_model_type when it is required by the function. This led to the file being passed in as the type.

New behavior

Behaves as expected

Breaking change

• Yes
• No

Additional information

N/A

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.43%. Comparing base (e1a2061) to head (cf98bb3).
Report is 30 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #743      +/-   ##
===========================================
+ Coverage    75.99%   76.43%   +0.44%     
===========================================
  Files           95       95              
  Lines        11015    11078      +63     
===========================================
+ Hits          8371     8468      +97     
+ Misses        2644     2610      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Gui-FernandesBR]

Nice catch!

Can you run black again please? @WilliamArmst

I am wondering whether we should release this BUG in a minor version (v1.7.1).

[WilliamArmst]

I'm not sure what running black again means, if it's the local tests I'll have to wait until I get back from classes.

This is a pretty small fix and even without it, I think updating the date sometimes works anyways for some reason? It doesn't make sense to me, but it only became an issue for me when I tried doing batch simulations with multiple dates. Ultimately up to you if you want to put it into a bugfix.

[WilliamArmst]

Is it failing because the linter wants this?

self.set_atmospheric_model(
        type=self.atmospheric_model_type,
        file=self.atmospheric_model_file,
        dictionary=self.atmospheric_model_dict,
)

[Gui-FernandesBR]

Is it failing because the linter wants this?

self.set_atmospheric_model(
        type=self.atmospheric_model_type,
        file=self.atmospheric_model_file,
        dictionary=self.atmospheric_model_dict,
)

Yes!

The code line should not exceeds 88 length positions.

Black is one of our linters. Running make format should work. you can learn more about it here: https://docs.rocketpy.org/en/latest/development/style_guide.html

The base branch was changed.