-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Rotational EOMs Not Relative To CDM #674
BUG: Rotational EOMs Not Relative To CDM #674
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #674 +/- ##
===========================================
- Coverage 75.95% 75.87% -0.08%
===========================================
Files 85 85
Lines 10079 10085 +6
===========================================
- Hits 7655 7652 -3
- Misses 2424 2433 +9 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Gui-FernandesBR <[email protected]>
…hub.com/RocketPy-Team/RocketPy into bug/rotational-eoms-not-relative-to-cdm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Info
There were two errors with calculations of the
u_dot
andu_dot_generalized
The first error has been in the code since da91db9 aka the first ever commit!
Special thanks to @kevin-alcaniz for finding this