TST: Prometheus acceptance test with apogee criteria #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phmbressan
approved these changes
May 16, 2024
Gui-FernandesBR
force-pushed
the
tst/prometheus-acceptance-test
branch
from
3327620 to
b3c732c
Compare
Gui-FernandesBR
force-pushed
the
tst/prometheus-acceptance-test
branch
from
b3c732c to
6df04c3
Compare
…ocketPy-Team/RocketPy into tst/prometheus-acceptance-test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #602 +/- ##
===========================================
+ Coverage 73.56% 73.58% +0.01%
===========================================
Files 70 70
Lines 10313 10313
===========================================
+ Hits 7587 7589 +2
+ Misses 2726 2724 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant) (we don't put tests in the CHANGELOG)New behavior
A new acceptance test, this time only the apogee is going to be asserted, due to the lack of time. However, the rocket flights up to 4km, extending our previous acceptance tests.
Breaking change
Additional information
None