-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: adds new stability margin methods to flight #572
ENH: adds new stability margin methods to flight #572
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #572 +/- ##
===========================================
+ Coverage 72.62% 72.65% +0.03%
===========================================
Files 59 59
Lines 9607 9614 +7
===========================================
+ Hits 6977 6985 +8
+ Misses 2630 2629 -1 ☔ View full report in Codecov by Sentry. |
c8b26b6
to
2940138
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just made a comment regarding the time at which simulation begin and if an initial solution or #568 change expected behavior of this method.
2940138
to
1264a67
Compare
…ps://github.com/RocketPy-Team/RocketPy into enh/adds-new-stability-margin-methods-to-flight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new properties should be added to flight.prints as well!
…ect initial time - This also adopts f-string interpolation for the initial_conditions prints
Thank you for your suggestion. I solved it in c9cc0de Can you re-review please? I need your approve now that you requested changes |
Got some inspiration from this PR and decided to refactor the whole flight_prints.py module directly: #579 |
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)New behavior
Use the new properties to access stability margin at specific times.
This will be useful for the Monte Carlo analyses.
Breaking change
Additional information