-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Update CSV Header Related Docs #495
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #495 +/- ##
===========================================
+ Coverage 71.05% 71.14% +0.08%
===========================================
Files 55 55
Lines 9262 9276 +14
===========================================
+ Hits 6581 6599 +18
+ Misses 2681 2677 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Looks Good To Me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.
@@ -37,6 +37,7 @@ straightforward as possible. | |||
### Changed | |||
|
|||
- ENH: Function Reverse Arithmetic Priority [#488](https://github.com/RocketPy-Team/RocketPy/pull/488) | |||
- DOC: Update Header Related Docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MateusStano you don't need to include this in the change log. From the user's perspective, it's irrelevant.
Pull request type
Checklist
CHANGELOG.md
has been updated (if relevant)Current behavior
Docs related to reading files mentioned that the files must contain no headers
New behavior
Now those docs mention that the files can contain headers
Breaking change