BUG: Function breaks if a header is present in the csv file #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 70.89% 70.91% +0.02%
==========================================
Files 55 55
Lines 9258 9261 +3
==========================================
+ Hits 6563 6567 +4
+ Misses 2695 2694 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- single line headers are now officially supported... - with or without quotes. - The docstring was updated.
Gui-FernandesBR
changed the title
Gui-FernandesBR
approved these changes
Nov 25, 2023
There was a problem hiding this comment.
LGTM!
All tests are passing locally, including with the --run-slow option
The check_user_inputs method is raising more problems than what I thought in the beginning. Improvements for this method are welcome, and I believe there's already an issue for that.
Good news: docs are passing! See https://docs.rocketpy.org/en/bug-v1.1.1-docs-build/
phmbressan
commented
Nov 25, 2023
MateusStano
requested changes
Nov 26, 2023
giovaniceotto
requested changes
Nov 26, 2023
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
Co-authored-by: Giovani Hidalgo Ceotto <[email protected]>
MateusStano
approved these changes
Nov 26, 2023
Gui-FernandesBR
approved these changes
Nov 26, 2023
giovaniceotto
approved these changes
Nov 26, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
The
Function.__check_user_inputsdid not support headered csv, which caused an error on docs build.New behavior
The support for headered csv was added and there was a
LiquidMotorexample in the docs that needed refactor to the new cap height definition.Breaking change