MNT: solve warnings #470
Merged
MNT: solve warnings #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix colormap get method avoiding deprecation from matplotlib - Fix interpolation/extrapolation warnings in Function class - avoid using Function.plot2D old method - delete the too general exception from the funcify.
LiquidMotor class - There's a problem when someone passes a mass flow curve with different a discretization than the thrust curve. (which is the case for the SEBLM motor) - I'm raising a new error to allow the user to solve the issue before continuing.
Gui-FernandesBR
added
Tests
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #470 +/- ##
===========================================
- Coverage 70.86% 70.80% -0.07%
===========================================
Files 55 55
Lines 9227 9234 +7
===========================================
- Hits 6539 6538 -1
- Misses 2688 2696 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Fix variable naming "xinitial", I also checked this is nto used in other classes - update interpolation and extrapolation methods usage - remove useless raises or warnings.
Merged
phmbressan
reviewed
Nov 19, 2023
MateusStano
reviewed
Nov 19, 2023
phmbressan
approved these changes
Nov 19, 2023
- Fix exhaust velocity calculation for non-zero mass flow rates - remove useless if statement - change if to elif statement. - all the tested passing without warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
You run the tests, they all pass, but there are still some warnings behind.
New behavior
Using the
pytest -v -W errorflag I was able to identify some warnings in the execution and give them the proper treatment.Please read the commits descriptions for more details.
Breaking change
Additional information
In the future we may want to update the SEBML curve to avoid getting in the new warning