DOC: refactor dispersion analysis notebook #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Gui-FernandesBR,
MateusStano and
phmbressan
Gui-FernandesBR
added
Docs
Gui-FernandesBR
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Works on my machine. Great solve, @giovaniceotto !!
A couple of commentaries tho:
- Remember to apply black before pushing. I wonder if our linter should also be blaking .ipynb files. To use black on notebooks:
pip install black[jupyter] - The
parachute_drop_from_helicopter.ipynbexample is still not updated, but no worries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
Current behavior
Dispersion Analysis Notebook does not work in v1 since it still uses camelCase.
New behavior
Minor changes were made to the notebook to support v1.
Breaking change
Additional information
Due to time constrains, the number of simulations executed were just 100.
Fake data was used for new parameters such as motor casing inertia tensor.