-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: new set of tests to the Flight class #408
Conversation
And of course it didn't work out of windows system (great!!) I'm converting this to draft, temporarily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging the develop branch into this one actually solved the problem that was blocking this PR.
So I believe we are good to go!
I can't merge it bc we need an approval first. Asking for help here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. I have updated some old docstrings in my latest commits.
Before merging, I would only double check if the numbers of the new tests are still valid (the ones that come from sim results) since there was a gap of time between this PR being implmented and now.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
Code base additions (for bug fixes / features):
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyWhat is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information
beta/v1.0.0