Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuselage): Responsive CardControls #1443

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+20 −1
Open

fix(fuselage): Responsive CardControls #1443

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2b03cb5
Added flex-wrap to CardControls css
Barrylimarti Sep 3, 2024
497f0dd
Changed Cardcontrol component to use Box for similar behaviour
Barrylimarti Sep 3, 2024
b2d6752
Added different behaviour for horizontal cards
Barrylimarti Sep 3, 2024
b3e0f35
Merge branch 'main' into fix/card-responsiveness
Barrylimarti Sep 7, 2024
c74faaa
prettier and linting issues fixed
Barrylimarti Sep 18, 2024
7d42b6a
Changeset added
Barrylimarti Sep 18, 2024
c01c2db
Removed the box implementation
Barrylimarti Sep 18, 2024
23a7cb4
Added conditional css using mixin
Barrylimarti Sep 18, 2024
6a4cdc3
Merge bugs fixed
Barrylimarti Sep 19, 2024
606421d
Mouse event handler type added
Barrylimarti Sep 19, 2024
f2f09a3
Merge branch 'main' into fix/card-responsiveness
Barrylimarti Oct 20, 2024
f26cf39
Update .changeset/purple-shirts-boil.md
Barrylimarti Oct 22, 2024
e2a79ef
Update packages/fuselage/src/components/Card/CardControls.tsx
Barrylimarti Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/fuselage/src/components/Card/Card.styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,13 @@ $card-hero-padding: lengths.padding(28);
display: flex;
align-items: center;
}
&__controls{
flex-wrap: wrap;
}
&__horizontal &__controls{
flex-wrap: nowrap;
&--wrap{
flex-wrap: wrap;
}
}
}
17 changes: 14 additions & 3 deletions packages/fuselage/src/components/Card/CardControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
const CardControls = ({ ...props }) => (
<div className='rcx-card__controls' {...props} />
);
import { useBreakpoints } from '@rocket.chat/fuselage-hooks';
import Box from '../Box/Box';

const CardControls = ({...props }) => {
const breakpoints = useBreakpoints();
const isMobile = !breakpoints.includes('sm');
return (
<Box
rcx-card__controls
rcx-card__controls--wrap={isMobile}
{...props}
/>
)
}
Barrylimarti marked this conversation as resolved.
Show resolved Hide resolved

export default CardControls;