chore: add userId and rcToken on attachmentURL only if protect files is enabled #6078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Modified formatAttachmentUrl to append rc_token and rc_uid only when FileUpload_ProtectFiles is enabled. This prevents unnecessary URL parameters when the setting is disabled.
Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-739
How to test or reproduce
(PS: to make it easier, use a console.log on formatAttachmentUrl results.)
Screenshots
Types of changes
Checklist
Further comments