Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add userId and rcToken on attachmentURL only if protect files is enabled #6078

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Dec 26, 2024

Proposed changes

Modified formatAttachmentUrl to append rc_token and rc_uid only when FileUpload_ProtectFiles is enabled. This prevents unnecessary URL parameters when the setting is disabled.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-739

How to test or reproduce

  • Log in a workspace that you can change Protect Upload Files;
  • Open an room with attachments;
    (PS: to make it easier, use a console.log on formatAttachmentUrl results.)

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review December 26, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant