Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Replies rendering images #3396

Closed
wants to merge 12 commits into from
Closed

Conversation

gerzonc
Copy link
Contributor

@gerzonc gerzonc commented Sep 21, 2021

Proposed changes

Based on #2564
Render images on ReplyPreview and Reply components

Issue(s)

Closes #704

How to test or reproduce

  • Quote a message with or without attachment (should render an image – if is an image – on preview and its type if it doesn't have a description)
  • Quote a quote message with or without attachment (shouldn't render an image but should show you the original message replied)

Screenshots

Before After
image image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@gerzonc gerzonc marked this pull request as draft October 8, 2021 13:36
@gerzonc gerzonc mentioned this pull request Mar 14, 2022
10 tasks
@diegolmello diegolmello deleted the fix.reply-render-images branch March 15, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] Replies don't render images
2 participants