Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added 'Mentions you' and 'Mentions user' tooltips for mentioned users & underline on hover #859

Conversation

dhairyashiil
Copy link
Contributor

Brief Title

Feat: Added 'Mentions you' and 'Mentions user' tooltips for mentioned users & underline on hover

Acceptance Criteria fulfillment

  • Show correct tooltip: If a mention is for the logged-in user, show the tooltip with the text "Mentions you". For other users, show "Mentions user".
  • Styling: On hover, an underline should appear below the text.

Fixes #858

Video/Screenshots

mention.tooltip.and.underline.on.hover.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-859 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

There are other tooltips too for @ALL and @here something like this.. Make sure you account those too.. if we are adding it.. though this doesn't look much necessary

@dhairyashiil
Copy link
Contributor Author

There are other tooltips too for @ALL and @here something like this.. Make sure you account those too.. if we are adding it.. though this doesn't look much necessary

Thank you, @Spiral-Memory, for the review. I added tooltips for the remaining two cases. I somewhat agree with you that it doesn't seem entirely necessary, but for the case of "Mentions you," I think it is important.

For example, suppose there are two people in the room with similar usernames like 'dhairi12' and 'dhairl12'.
The only difference is the characters "i" and "l" before the number 1.
Without the tooltip, the user would have to constantly check the chat to determine whether they were mentioned or if it was the other user. They would need to check the spelling or navigate to the mentions section in the sidebar.
But with this tooltip feature, they only need to hover over it.

@dhairyashiil
Copy link
Contributor Author

UI after recent commit:

hover.on.mention.all.and.here.mp4

@Spiral-Memory
Copy link
Collaborator

There are other tooltips too for @ALL and @here something like this.. Make sure you account those too.. if we are adding it.. though this doesn't look much necessary

Thank you, @Spiral-Memory, for the review. I added tooltips for the remaining two cases. I somewhat agree with you that it doesn't seem entirely necessary, but for the case of "Mentions you," I think it is important.

For example, suppose there are two people in the room with similar usernames like 'dhairi12' and 'dhairl12'. The only difference is the characters "i" and "l" before the number 1. Without the tooltip, the user would have to constantly check the chat to determine whether they were mentioned or if it was the other user. They would need to check the spelling or navigate to the mentions section in the sidebar. But with this tooltip feature, they only need to hover over it.

Not exactly @dhairyashiil
It is already differenciated with color

@Spiral-Memory Spiral-Memory merged commit bcc7e95 into RocketChat:develop Jan 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add 'Mentions you' and 'Mentions user' tooltips for mentioned users & underline on hover
2 participants