-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Added 'Mentions you' and 'Mentions user' tooltips for mentioned users & underline on hover #859
Feat: Added 'Mentions you' and 'Mentions user' tooltips for mentioned users & underline on hover #859
Conversation
…sers & underline on hover
Thank you, @Spiral-Memory, for the review. I added tooltips for the remaining two cases. I somewhat agree with you that it doesn't seem entirely necessary, but for the case of "Mentions you," I think it is important. For example, suppose there are two people in the room with similar usernames like 'dhairi12' and 'dhairl12'. |
UI after recent commit: hover.on.mention.all.and.here.mp4 |
Not exactly @dhairyashiil |
Brief Title
Feat: Added 'Mentions you' and 'Mentions user' tooltips for mentioned users & underline on hover
Acceptance Criteria fulfillment
Fixes #858
Video/Screenshots
mention.tooltip.and.underline.on.hover.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-859 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.