Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add channel-name in msgBox #857

Merged

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 9, 2025

Brief Title

Acceptance Criteria fulfillment

  • Add channel name in msg-box as placeholder.

Fixes #856

Video/Screenshots

image

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spiral-Memory Spiral-Memory merged commit 8b05419 into RocketChat:develop Jan 11, 2025
4 checks passed
@Spiral-Memory Spiral-Memory added the chore a subtle fix label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a subtle fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message box placeholder is not showing channel name
2 participants