-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement loading of older messages functionality #810
base: develop
Are you sure you want to change the base?
Conversation
Hey @SinghaAnirban005, could you please check something? In your workspace, try reducing the number of messages returned by the API (say 4 or 6 maybe for testing purpose). After that, try loading the messages again. Are the older messages being fetched correctly ? I noticed that you're increasing the offset by 50 everytime. |
The endpoint responds back with around 50 as limit so having offset as 4 or 6 would not make sense . In every batch around 50 is limit so is the offset accordingly, and yes it does fetch all messages . |
No no I am not telling you to set offset increment to 4 or 6. You said the api returns in batches of 50 but you can modify this value from your workspace right? I am telling you to try reducing this value. |
Well , got it ... |
174e2a5
to
efa6ff1
Compare
Hey @SinghaAnirban005 Just one request: the alignment isn’t very good. Can you move the loader a bit higher, farther to the date? Right now, it looks too close. Also, how did it fetch older messages before? Was there no such functionality earlier? |
There was no provision to fetch older messages earlier |
@Spiral-Memory EmbeddedChat._.Simple.-.Simple.Storybook.-.Personal.-.Microsoft.Edge.2025-01-11.19-20-03.mp4 |
Brief Title
Implement Loading of Older Messages Feature
Acceptance Criteria fulfillment
getOlderMessages
to fetch older messages.Fixes #793
Video/Screenshots
EmbeddedChat._.Simple.-.Simple.Storybook.-.Personal.-.Microsoft.Edge.2025-01-06.02-18-31.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-810 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.