-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a feature to copy messages and copy link in message tool box #710
Added a feature to copy messages and copy link in message tool box #710
Conversation
I noticed that you’ve made changes to the theme editor for consistency as well. Could you attach a video demonstrating that it works fine? I’m unable to see those changes in the deployed version. Not sure if we deployed the latest |
ad575e6
to
bf1ed53
Compare
Hey @Spiral-Memory, thanks for pointing it out, just regarding that only I want to ask you something. I have watched your layout_editor video and in that I observed that you added that theme json in EmbeddedChat rc-app, and in that I have also uploaded my theme json generarted from layout_editor, but it does not reflected any changes. also I observed you have added client-id and client-secret so can you tell how did you get those? |
After uploading your JSON and saving it, you need to check in Storybook where the remote settings are applied. There is a prop, As for the client ID and secret, I’m not sure which one you’re referring to. |
For now, you can remove all the changes from layout_editor in this PR, so i can merge this, maybe make it consistent in some other pr |
Okay then, I will update these changes in my next pr in future |
Hey can you re-run this workflow https://github.com/RocketChat/EmbeddedChat/actions/runs/12453015921, I think the pages-deployment workflow is not triggered or might got skipped and due to that the changes might not reflected. do it after any build-pr or deploy-pr workflow is completed |
ok do not re-run it changes are visible |
Acceptance Criteria fulfillment
Fixes #709
Video/Screenshots
Screencast.from.22-12-24.02.04.35.PM.IST.webm
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-710 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.