feat: Implemented search member and display member info feature #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @abirc8010 Looks good to me. Great work! However, the width of the user info side panel is not the same as the others. Could you please fix that in this PR? Also, please add the required padding to the other side panels, as I mentioned in the last merged PR. |
Spiral-Memory
approved these changes
Dec 22, 2024
|
Let me know once you fix both |
…beddedChat into feat/search-members
|
Hey @Spiral-Memory I have fixed the issues. |
Spiral-Memory
approved these changes
Dec 22, 2024
|
Great work @abirc8010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
Implemented a search and display member info feature that allows searching members and showing detailed information on clicking a particular member.
Acceptance Criteria fulfillment
members.filterbased onusernameandnameattributeuseSetExclusiveStateanduseUserStoreto display the userInfo by attaching an onClick event insideRoomMemberItemFixes #707
Video/Screenshots
Screencast.from.2024-12-21.22-15-54.webm
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-708 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.