fix: ensure pin permission changes reflect without requiring user logout #688
Conversation
|
Hey @SinghaAnirban005, still a new thing got arised, check this A tip: Do not be in hurry on raising the pull requests okay you first review your code from your side be cleared before raising the pull request so that any edge cases or bug does not occur |
|
@devanshkansagra it works absolutely fine on my end EmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2024-12-18.00-04-11.mp4Also the reason why you are not being able to take away the pin permission from admin user is that by default an Admin user has two specific roles ['user', 'Admin'] so if you want to restrict admin from pinning messages you must unselect both the admin and user checkboxes . |
|
Oh okay. But still in case of normal user it is failing see |
|
It still works !! EmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2024-12-18.00-48-58.mp4 |
|
Then why this is still occuring on my side? I have also pulled the latest changes in my fork(devanshkansagra/EmbeddedChat), including this merge. @Spiral-Memory could you please verify this on your side as well? |
|
Won't be able to verify now |
|
okay no problem |
Brief Title
Fix: Pin Permission Changes Not Reflected Without User Logout
Acceptance Criteria fulfillment
Pin permission changes made by the admin are now immediately reflected for the user after a page refresh.
No need for the user to log out and log back in to see the updated permissions.
Fixes #686
Video/Screenshots
EmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2024-12-17.02-01-38.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-688 after approval. Contributors are requested to replace
<pr-number>with the actual PR number.