Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/fix] Added sending state to file upload modal #524

Merged
merged 2 commits into from
Mar 19, 2024
Merged

[Feat/fix] Added sending state to file upload modal #524

merged 2 commits into from
Mar 19, 2024

Conversation

thesynthax
Copy link
Contributor

Brief Title

Added sending state to file upload modal

Fixes #521

Video/Screenshots

pr.mp4

@thesynthax thesynthax mentioned this pull request Mar 19, 2024
Closed
@thesynthax
Copy link
Contributor Author

Thanks for the review, I'll be on it!

@Spiral-Memory
Copy link
Collaborator

@thesynthax Please attach a new video after these changes.

@thesynthax
Copy link
Contributor Author

thesynthax commented Mar 19, 2024 •
edited
Loading

pr524_2.mp4

@Spiral-Memory
Copy link
Collaborator

LGTM!

@sidmohanty11 sidmohanty11 merged commit 166f36e into RocketChat:develop Mar 19, 2024
3 checks passed
@sidmohanty11 sidmohanty11 added the chore a subtle fix label Mar 19, 2024
@thesynthax thesynthax deleted the sending-state-file-upload branch March 19, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spiral-Memory Spiral-Memory Spiral-Memory approved these changes

@sidmohanty11 sidmohanty11 sidmohanty11 approved these changes

Assignees
No one assigned
Labels
chore a subtle fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add loading state to File upload modal
3 participants
@thesynthax @Spiral-Memory @sidmohanty11