fix: infinite render and console errors due to search component #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sidmohanty11 , there is a minor bug introduced after recent merge #497 while rendering the search component. It was rendering infinitely. I have tried fixing it. Please review this as early as possible. |
|
@Spiral-Memory Thanks for spotting this 👍 |
No worries, bro 😃! We are here to help each other. |
sidmohanty11
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
I have observed some minor bugs introduced by PR #497 , and this PR is intended to address these issues of infinite renders and console errors as quickly as possible
Acceptance Criteria Fulfillment
Fixes #502
Video/Screenshots
2024-03-08.22-16-36.mp4