Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added preview link #495

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

Spiral-Memory
Copy link
Collaborator

Brief Title

Added a feature to display link previews, which were not visible earlier.

Acceptance Criteria fulfillment

  • Added link preview feature.
  • Included an option to show/hide the link preview.
  • Introduced the necessary icon.

Fixes #494

Video/Screenshots

2024-03-05.17-02-20.mp4

Added another video to demonstrate that users can indeed click on the image, link, or the source to navigate to the link, just like in Rocket Chat.

2024-03-05.17-11-37.mp4

@Spiral-Memory Spiral-Memory force-pushed the fix/link-preview branch 3 times, most recently from f65558d to f06647b Compare March 5, 2024 14:57
added chevron icons

added dropdown to toggle link preview
@Spiral-Memory
Copy link
Collaborator Author

Ready for review ..

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Spiral-Memory !! Just added a minor comment

@sidmohanty11 sidmohanty11 merged commit c49d93c into RocketChat:develop Mar 8, 2024
3 checks passed
@Spiral-Memory
Copy link
Collaborator Author

LGTM! Thanks @Spiral-Memory !! Just added a minor comment

Done @sidmohanty11 😃, Removed the console log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Link preview is not available.
2 participants