Feat/#485 files menu option - sidebar #491
Conversation
|
Will fix the linting issues. Meanwhile, please review the PR. |
|
Hi @sidmohanty11 @abhinavkrin . Please review the PR. |
|
Hi @sidmohanty11 . Please take a look into this whenever you are free. |
| @@ -135,7 +135,7 @@ const AudioMessageRecorder = () => { | |||
| if (file) { | |||
| setFile(null); | |||
| } | |||
| }, [isRecorded, file]); | |||
| }, [isRecorded, file, ECOptions.enableThreads, RCInstance, threadId]); | |||
There was a problem hiding this comment.
Are you sure about this? There are some linting warnings for which a quick fix of adding dependencies actually messes things up and creates issues. If you are sure then fine
There was a problem hiding this comment.
I have faced such issues. That's why just letting you know...
There was a problem hiding this comment.
I think tried to check after adding these as dependencies. Everything was working fine I guess.
Still I'll once more look into to be sure.
Thanks for pointing this out.
There was a problem hiding this comment.
I would suggest keeping the linting warnings as it is if you are not sure about it. Linting warnings won't create any issues while committing.
There was a problem hiding this comment.
Yup agreed with @Spiral-Memory , can you please check @umangutkarsh if these are actually required and if its completely safe to go ahead with/without them
There was a problem hiding this comment.
Hey @sidmohanty11 @Spiral-Memory . I've reverted and removed them from the dependencies so that nothing breaks.
Also one thing, after pulling the latest changes from the recent commits. The 'send-message' button is not working as expected.
It's opening this modal. Just wanted to confirm if this is something added or an issue.
Please let me know. Thanks.
There was a problem hiding this comment.
Thank you so much, @umangutkarsh , for the notice. Yes, this was a new feature introduced to handle excessively long messages, but it wasn't intended to work this way. Yesterday, I made some changes to the sendMessage function and added a parameter there, which defaults to false, to check whether it is an attachment. By pressing Enter, everything was working fine. However, when using the send-btn, I was mistakenly assigning that function rather than calling it like ()=>sendMessage(). That's the reason this issue originated.
Thank you so much for the notice. I have just fixed it in #510. @sidmohanty11 , please review it.
| @@ -50,7 +50,7 @@ const EmbeddedChat = ({ | |||
| useEffect(() => { | |||
| setToastbarPosition(toastBarPosition); | |||
| setShowAvatar(showAvatar); | |||
| }, [toastBarPosition, showAvatar]); | |||
| }, [toastBarPosition, showAvatar, setShowAvatar, setToastbarPosition]); | |||
There was a problem hiding this comment.
I don't think it will cause an issue here with dependencies, still confirm it
Also confirm, there is no console errors. Rest LGTM!
Brief Title
Added a new section "Files Menu" where users can see all the files shared in the channel. It also supports a 'search file' functionality to search files by filtering out their name.
Acceptance Criteria fulfillment
Note:
Fixes #485
Video/Screenshots
files-menu.webm