Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download function and file name to messages attachments #489

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

JeffreytheCoder
Copy link
Contributor

@JeffreytheCoder JeffreytheCoder commented Mar 1, 2024

Acceptance Criteria fulfillment

  • Shows file name for the attachment
  • Have a button that downloads the attachment

Fixes #488

Video/Screenshots

attachment_metadata

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool @JeffreytheCoder can you please take a look at the CI errors?

@JeffreytheCoder
Copy link
Contributor Author

Cool @JeffreytheCoder can you please take a look at the CI errors?

Fixed. Ready for review

@sidmohanty11 sidmohanty11 merged commit a6cd592 into RocketChat:develop Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add download function and file name to messages attachments
2 participants