feat: UiKit Modal Support #481
Conversation
Spiral-Memory
force-pushed
the
feat/uikit-support
branch
7 times, most recently
from
69bd4f7 to
9fe12a7
Compare
|
Hey @abhinavkrin , I have successfully implemented the UIKitModal with all the required components mentioned in the TODO in the code, without using the fuselage. Additionally, I have addressed some minor issues and styling related to it. The UIKitModal is rendering properly in all the cases I have tested. To conduct testing, I used the Notion app due to its many different modals and properties. However, I haven't implemented the task 2 of this issue, which involves capturing events and sending them to Rocket Chat for processing. I am unable to understand how the actions are being dispatched. I need your help with this or suggest collaboration with other contributor to complete it. Even after checking the Rocket Chat app and live chat app, I'm still not sure how the actions are sent. Right now, the rendering task of this issue is completed. |
Spiral-Memory
force-pushed
the
feat/uikit-support
branch
2 times, most recently
from
b79fd6b to
6ca9e33
Compare
added PreviewBlock fixed link visibility styling remaining
Spiral-Memory
force-pushed
the
feat/uikit-support
branch
from
6ca9e33 to
dd3623b
Compare
There was a problem hiding this comment.
Hey @Spiral-Memory awesome work! Just wanted to know is it safe to merge this? As this will enable us the UI right? Just not the functionalities? We can take up the functionalities on the subsequent PR.
|
Yes @sidmohanty11 , It's completely safe to merge it, as far as i have tested, it doesn't introduce any bugs.. also if I find any, i will immediately fix it, so no worries. Yes only functionality has to be implemented now. |
|
Awesome! |
Brief Title
Implemented UIKit Modal Rendering to enable the rendering of UIKit modals within EmbeddedChat.
Fulfillment of Acceptance Criteria
Fixes #474
Video/Screenshots
2024-02-27.18-00-47.mp4