chore: Commented out uiKitModal code instead of disabling lint error #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abhinavkrin, Done. The entire code was dependent on those imports, had to comment all. Check if this won't cause any issue to our project. |
Spiral-Memory
force-pushed
the
fix/comment-UiKitModal-file
branch
from
1f98d28 to
47a7f1e
Compare
|
Hey I should close this PR, since I remember UiKitModal used to render before. We should go for the fix. |
|
Yaa sure, currently i don't have understanding of what exactly uikitmodal here does. will discuss with you and work on it. |
Spiral-Memory
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented out uiKitModal code instead of disabling lint error anded TODO as per our discussion