-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#274 replace message components with custom components #277
Feat/#274 replace message components with custom components #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great Work
Hi @umangutkarsh, I've noticed the search message feature isn't working as expected after the recent changes in this PR. Could you please take a look? Also, it would be great if we could test out the functionalities before finalizing PRs. This helps make the review process more efficient. Thanks for your understanding and assistance! |
Hi @abhinavkrin, I'll look into it. Also how should I test it? Can't view the components in storybook. |
…mponents (RocketChat#277)" This reverts commit 49a8bd5.
Hi @abhinavkrin, I've made some changes. I need to test those. Would be helpful if you guide me. |
Please follow the readme files to set up project locally. One good practice is to use the project and play with it in order to understand how it works and what it provides. |
I've set the project locally. And there is no issues with the storybook, and auth dev environment. But I was not able to setup the api dev-environment. |
Api and Auth are not required to be running to test EmbeddedChat. They are build and installed in EmbeddedChat as dependencies. |
…ustom components (RocketChat#277)" (RocketChat#278)" This reverts commit 9c68954.
…RocketChat#277) * added-babel-config * file-modifications * imports * mods-in-SearchMessage.js
…mponents (RocketChat#277)" (RocketChat#278) This reverts commit 49a8bd5.
Brief Title
Replaced the components
Message, MessageReactions, MessageDivider
imported in/packages/react/src/components/SearchMessage/SearchMessage.js
with custom Message.js, MessageReactions.js and MessageDivider.js files.Acceptance Criteria fulfillment
@rocket.chat/fuselage
import inSearchMessage.js
Fixes #274