Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#274 replace message components with custom components #277

Conversation

umangutkarsh
Copy link
Contributor

@umangutkarsh umangutkarsh commented Oct 18, 2023

Brief Title

Replaced the components Message, MessageReactions, MessageDivider imported in /packages/react/src/components/SearchMessage/SearchMessage.js with custom Message.js, MessageReactions.js and MessageDivider.js files.

Acceptance Criteria fulfillment

  • Removed @rocket.chat/fuselage import in SearchMessage.js
  • Implemented custom components.
  • Imported custom components.

Fixes #274

Copy link
Member

@abhinavkrin abhinavkrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great Work

@abhinavkrin abhinavkrin merged commit 49a8bd5 into RocketChat:develop Oct 18, 2023
abhinavkrin added a commit that referenced this pull request Oct 18, 2023
abhinavkrin added a commit that referenced this pull request Oct 18, 2023
@abhinavkrin abhinavkrin added the invalid This doesn't seem right label Oct 18, 2023
@abhinavkrin
Copy link
Member

abhinavkrin commented Oct 18, 2023

Hi @umangutkarsh,

I've noticed the search message feature isn't working as expected after the recent changes in this PR. Could you please take a look?

Also, it would be great if we could test out the functionalities before finalizing PRs. This helps make the review process more efficient.

Thanks for your understanding and assistance!

@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Oct 18, 2023

I've noticed the search message feature isn't working as expected after the recent changes in this PR. Could you please take a look?

Also, it would be great if we could test out the functionalities before finalizing PRs. This helps make the review process more efficient.

Thanks for your understanding and assistance!

Hi @abhinavkrin, I'll look into it. Also how should I test it? Can't view the components in storybook.
Thanks

umangutkarsh added a commit to umangutkarsh/EmbeddedChat that referenced this pull request Oct 18, 2023
@umangutkarsh
Copy link
Contributor Author

Hi @umangutkarsh,

I've noticed the search message feature isn't working as expected after the recent changes in this PR. Could you please take a look?

Also, it would be great if we could test out the functionalities before finalizing PRs. This helps make the review process more efficient.

Thanks for your understanding and assistance!

Hi @abhinavkrin, I've made some changes. I need to test those. Would be helpful if you guide me.
Thanks for this.

@abhinavkrin
Copy link
Member

Please follow the readme files to set up project locally. One good practice is to use the project and play with it in order to understand how it works and what it provides.

@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Oct 18, 2023

Please follow the readme files to set up project locally. One good practice is to use the project and play with it in order to understand how it works and what it provides.

I've set the project locally. And there is no issues with the storybook, and auth dev environment. But I was not able to setup the api dev-environment.
Would be helpful if you help out.
Thanks

@abhinavkrin
Copy link
Member

Api and Auth are not required to be running to test EmbeddedChat. They are build and installed in EmbeddedChat as dependencies.

umangutkarsh added a commit to umangutkarsh/EmbeddedChat that referenced this pull request Oct 18, 2023
anjy7 pushed a commit to anjy7/EmbeddedChat that referenced this pull request Nov 7, 2023
…RocketChat#277)

* added-babel-config

* file-modifications

* imports

* mods-in-SearchMessage.js
anjy7 pushed a commit to anjy7/EmbeddedChat that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace fuselage's Message, MessageReaction, and MessageDivider component with our own component
2 participants