fix: install Deno manually #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tianon do you think this is ok? Deno started generating the sha256sum only here at v2 denoland/deno#25869 Currently Deno v2 does not work with Rocket.Chat, but as far as we are able to use it (preferably v2.1) I'll update the Dockerfile with a checksum |
|
Created PR on the official-images repo (docker-library/official-images#17984). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately according to Docker docs we cannot rely on non-official images:
docker-library/official-images#17982 (comment)
So now we're installing Deno manually.. From what I could see, Deno started publishing
sha256sumfor their binaries on v2, which is not supported by Rocket.Chat at this point, so I'm installing the version 1.37.1 which is the version currently tested (see)