main: move musicCache to a cache folder #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since some music tend to become unavailable by time (thank you netease), it may be better to keep those cached music files when migrating, rather than remove them. |
|
Yes. Is there a reliable way to determine whether or not to delete those songs? If there's not, downloading them may be a better choice if some songs are really desired to be kept since we have mapping for downloaded files. |
KoishiMoe
added a commit
to KoishiMoe/electron-netease-cloud-music
that referenced
this pull request
Apr 27, 2022
从 Rocket1184#128 抄的 （2333
|
Maybe I should write some sort of music availablity checking procedure before merging this, and #129 . Comming soon™ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main: move musicCache to a cache folder
Move music cache to a cache folder. Delete the old cache.
Resolves: #124