This repository has been archived by the owner on Sep 17, 2019. It is now read-only.
Missxa bot merge #86
Open
Missxa bot merge #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If STMT --> Use DBSTD otherwise SPA has succeeded
State's String emotion variable changed as RoboyEmotion emotion. Some emotions added to RoboyEmotion. DoYouKnowMath tutorial is changed due to new emotion usage. Documentation updated.
* Enabled ContextTest * Added ConversationManagementTest * Enabled VerbalizerTest * Improved documentation * Fixed minor mistake in config.properties logging section
…added a few Neo4j rel, proper sentence capitalization in utils, added variablility in botboy state, rarely asking to play akinator, new phrases and question in verbalizer and resources, shuffle random list
Aevyz
reviewed
Sep 17, 2018
|
|
||
| private SpeechAction greet(Interpretation interpretation){ | ||
| return new SpeechAction(StatementBuilder.random(greetings)); | ||
| } | ||
|
|
||
| public static final RandomList<String> farewells = new RandomList<>( | ||
| "ciao", "goodbye", "cheerio", "bye", | ||
| "see you", "farewell", "bye-bye"); | ||
| "ciao", "goodbye", "cheerio", "bye", "farewell", "bye-bye"); |
There was a problem hiding this comment.
Is there a reason why see you is removed?
There was a problem hiding this comment.
yes, cause we want to answer "where can i see you?" which would never get through
Aevyz
reviewed
Sep 17, 2018
| @@ -37,6 +37,7 @@ | |||
| public static class Options { | |||
| @Option(gloss = "What CoreNLP annotators to run") | |||
| public List<String> annotators = Lists.newArrayList( | |||
| "tokenize", | |||
There was a problem hiding this comment.
Do we really need tokenize twice?
There was a problem hiding this comment.
@josephbirkner @Waguramu ?
git is the witness i havent touched that file :P
Aevyz
reviewed
Sep 17, 2018
Closed
|
Additional TODO (s):
|
… into wacker-open-day
… into wacker-open-day
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on DE + SM + BB finals state;
Changes: