-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release for F-Droid #1600
Conversation
Build tested and working 👍 |
umm no x86_64 librobo*.so's? |
The x86_64 are exactly the same https://github.com/RoboSats/robosats/tree/main/mobile/android/app/src/main/jniLibs/x86_64 , no changes |
next
I'll try to match the same version |
no joy, even matching your version with |
@linsui any ideas to fix this diff? |
See https://f-droid.org/docs/Reproducible_Builds/#rust. :) I can see that there are some paths. -/home/vagrant/.cargo/registry/src/index.crates.io-6f17d22bba15001f/num-bigint-0.4.4/src/bigint/convert.rs/home/vagrant/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jni-0.21.1/src/wrapper/jnienv.rscalling checked jni method: NewStringUTFjni::wrapper::jnienvlooking up jni method NewStringUTFJNIEnv*JNIEnvjnienv method not defined, returning errorNewStringUTF
+/root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/num-bigint-0.4.4/src/bigint/convert.rs/root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jni-0.21.1/src/wrapper/jnienv.rscalling checked jni method: NewStringUTFjni::wrapper::jnienvlooking up jni method NewStringUTFJNIEnv*JNIEnvjnienv method not defined, returning errorNewStringUTF |
ah, I thought I looked at that, nice catch, brb |
I got some paths cleaned up with
but the .so is filled with any idea how to clean this up too? I've searched for other ways to clean but didn't find the right command yet to remove the crates information from the .so file eg rust-lang/cargo#13171 and many more |
Looks like managing rebuilding in full, brb |
yeah, CARGO_HOME did it 🎉 all those trim and remap tricks were useless 🤷 @KoalaSat do merge this and maybe tag a new release so we can test reproducibility in full |
Congrats!!! Alright, we are planning a next release probably for next week. I'll keep you updated here 🚀 |
@licaon-kter new release just launched! |
What does this PR do?
These are changes requested by #1261 (comment) in order to prepare the app for the F-Droid repo:
librobonames
andlibrobohash
to its latest commit on RoboSats/robo-identities@c95a9f5Checklist before merging
pip install pre-commit
, thenpre-commit install
. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.