add new param current_status to /api/order cancel #1325
Conversation
also added ENUM_NAME_OVERRIDES in SPECTACULAR_SETTINGS, because without it when generating api-latest.yaml this warning is returned: Warning: encountered multiple names for the same choice set (CurrentStatusEnum). This may be unwanted even though the generated schema is technically correct. Add an entry to ENUM_NAME_OVERRIDES to fix the naming.
There was a problem hiding this comment.
This PR is solid and complete. We will be merging #1326 instead given that it implements the frontend fixes and has integration tests as well. But a few things from this PR can be implemented there for the best of both worlds 😄
Makes sense to split the reward as discussed on #1326. Please post an invoice for 40K Sats (+ week expiration if possible) 🚀
Closing.
| @@ -146,6 +146,9 @@ | |||
| } | |||
| }, | |||
| "REDOC_DIST": "SIDECAR", | |||
| "ENUM_NAME_OVERRIDES": { | |||
There was a problem hiding this comment.
I also learned it today, well yesterday, while searching how to remove that warning ahahaha
Sure, perfectly fine with me, I left some comments in #1326 |
Feel free to post the invoice in this threat or in the issue. Thank you! |
What does this PR do?
This PR introduces a new optional parameter
current_statusthat can be used when cancelling an order. The server checks ifcurrent_statusis the correct status of the order and returns an error without cancelling the order if it is not.This way a client can be sure to cancel an order just if the status is the one it specified.
Fixes backed and tests of #1311.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.