-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storing Groceries #520
Merged
kyordhel
merged 6 commits into
RoboCupAtHome:2019/restructure
from
johaq:storingGroceries
Feb 19, 2019
Merged
Storing Groceries #520
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aac1a38
Some proposed changes for the storing groceries task:
johaq 06649c2
updated score sheet for storing groceries
johaq 5d958eb
fixed typo in storing groceries score sheet
johaq d5aa19c
added back scenario name
johaq 773afb0
Added back object ranges. Removed clear area rule since I feel robots…
johaq c40d240
small grammar fix: In small table -> On small tables
johaq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly disagree with this change. It is necessary to keep fairness (even distribution among teams) and for logistical reasons. Further, the heavy and tiny objects are necessary due to bonus points (see scoresheet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that distribution has to be equal for all teams but I think that is something for the referees to decide on location and is not something that should or needs to be in the rulebook. Why not allow the referees the flexibility to decide: "Hey at this competition no team is really strong in manipulation let's use easier objects for everyone." And also if teams get stronger we do not need to update single numbers from year to year and keep more consistency in the rulebook over time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because scoring needs to be consistent among tests. This tests makes pick and place an object automatically worth ~100pts, so it can be taken as measure for assigning scores to other tests. Further, we are implying that each manipulation should not take more than one minute.
Besides, we need to be consistent in the three leagues (or at least between OPL and DSPL). If you leave the decision to the referees, the difficulty will vary between leagues and you have no consistent progression over the years.
Teams know:
So yes, a state machine can be used, but a more robust decision making will produce better results to maximize scoring. IMHO, that setup is way too complex for a state machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how this affects consistency among other tests.
Consistency among leagues I understand but don't the referees switch leagues anyway during a competition and talks are with referees of all leagues.
Consistency over the years I agree is lost a little here but definitely not entirely.
I prefer teams know:
-There are several objects on a table
-We get points for moving up to five of them
-Our robot should know which of the objects are easy to grasp for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe at least.
Let's hear other opinions from the @RoboCupAtHome/technical-commmittee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moriarty @balkce @justinhart @awesomebytes @allisonh-tri