Implement library for custom scaffolder actions. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Xantier
commented
Feb 20, 2024
•
Xantier
commented
- Add functionality to receive custom scaffolder action triggering
- Add context provider to handle action running
- Add workspace manager to retrieve and upload wanted scaffolder workspace from/to S3 based on provided presigned URLs
- Add CustomScaffolderAction class to wrap the needed endpoint calls to create a simpler library interface
- Add docs
|
This pull request has been linked to Shortcut Story #18723: Spike: Create epic for Custom Scaffolder Actions. |
Xantier
commented
Feb 20, 2024
Xantier
commented
Feb 20, 2024
Xantier
commented
Feb 20, 2024
Xantier
commented
Feb 20, 2024
Xantier
commented
Feb 20, 2024
Xantier
commented
Feb 20, 2024
| } | ||
|
|
||
|
|
||
| async log(content: string, context?: Record<string, string>) { |
There was a problem hiding this comment.
Simple custom scaffolder context which exposes a logger, workspace and the payload passed into when the action was triggered
Add docs
Xantier
changed the title
Xantier
commented
Mar 18, 2024
src/lib/entityProvider/constants.ts
Outdated
There was a problem hiding this comment.
entityProvider side of the agent is untouched, just moved to a folder
Xantier
commented
Mar 18, 2024
| ); | ||
|
|
||
| logger.info('File uploaded'); | ||
| const etag = (response?.headers?.etag as string)?.replaceAll('"', ''); |
There was a problem hiding this comment.
AWS S3 produces etags that are wrapped in ". It's implemented according to spec and will never change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.