Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/updates #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/updates #4

wants to merge 2 commits into from

Conversation

JishantSingh
Copy link

Hi @johnmastro ,
Regarding the two issues that have been listed, I have solved them and tested the following solutions in production.

  1. For number of rows>16k, i split the insert into multple statements.
  2. Special characters in json, enclosing the parsed json in $$ ensures proper escaping of special characters.

@DannyMoncada
Copy link

@JishantSingh @johnmastro I think this fix should get committed because I was facing the same problem handling special characters that were in my Google sheet and when I stumbled upon this fix, I implemented them and got the sheets to load as they should.

This is an extremely helpful tool (and there's nothing online that does this as seamlessly) so I appreciate you guys putting this together!!

@JishantSingh
Copy link
Author

@johnmastro can you please merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DannyMoncada DannyMoncada DannyMoncada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JishantSingh @DannyMoncada