JOBS-10957: Fix SQS error handling / general refactoring #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otanim
changed the title
otanim
requested review from
datashaman,
patrickarnold79,
otobio,
kingsleyudenewu and
ianmirungu
patrickarnold79
approved these changes
Oct 30, 2024
otobio
reviewed
Oct 30, 2024
otobio
reviewed
Oct 30, 2024
src/ServiceBusSQSChannel.php
Outdated
|
|
||
| $eventName = $params['events'][0]; | ||
|
|
||
| Log::info("{$eventName} sent to bus queue", [ |
There was a problem hiding this comment.
is there an opportunity for this bit to respect the dontreport config option too? :D
There was a problem hiding this comment.
scratch this wont make sense.. we need another config to determine the loglevel or quiet this donw altogether.. dontreport is used for something else entirely
otobio
approved these changes
Oct 30, 2024
datashaman
approved these changes
Oct 30, 2024
otanim
force-pushed
the
fix-sqs-error-handling
branch
from
36f774f to
d6a21d3
Compare
|
|
|
@datashaman, the builds are failing on GitHub, which is concerning. I ran the tests locally with these changes, and they passed. Can you check if the PR is applicable for merging and proceed if so? |
otanim
changed the title
ianmirungu
approved these changes
Nov 19, 2024
|
@otanim the builds are failing because of a change in your code. look at the failing build. fix the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Number:
https://oneafricamedia.atlassian.net/browse/JOBS-10957