Release 0.15.3

[ShahanaFarooqui]

Milestone covered with this release:
https://github.com/Ride-The-Lightning/RTL/milestone/43

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced a new sendPayment function for handling payments.
  • Added a new route for sending payments at /send.
  • Enhanced UI to display recommended fee rates in various components.
  • Added functionality for a currency unit converter and transactions report table.

• Bug Fixes

  • Improved error handling and logging for various payment processes.
  • Fixed conditions for displaying fee options in UTXO tables.

• Documentation

  • Updated README and licensing information for third-party packages.

• Style

  • Enhanced styling for dark and light themes across various components.

• Chores

  • Updated version number in package.json to 0.15.3-beta.
  • Refactored code for improved readability and maintainability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request encompasses extensive modifications across various files, primarily focusing on updates to ESLint configurations for TypeScript and HTML, changes to backend controllers and routes, enhancements to frontend components, and adjustments in styles. Key changes include the introduction of new functionalities, such as a payment sending feature, and the removal of deprecated functions. The updates also streamline error handling and improve user interface elements, particularly regarding fee displays in transaction modals. Additionally, the project version has been incremented, reflecting these comprehensive updates.

Changes

File	Change Summary
.eslintrc.json	Updated ESLint configuration for TypeScript and HTML files, including parser options and rules.
.github/workflows/ci.yml	Modified CI workflow to remove certain triggers, added version input, and updated action versions.
backend/controllers/cln/invoices.js	Changed endpoint for deleteExpiredInvoice function and updated response structure and logging.
backend/controllers/cln/offers.js	Modified URL endpoint casing in disableOffer function.
backend/controllers/eclair/channels.js	Simplified data structure in simplifyAllChannels and standardized error handling.
backend/controllers/lnd/channels.js	Removed postTransactions function, affecting payment processing logic.
backend/controllers/lnd/payments.js	Introduced sendPayment function for handling payment requests.
backend/routes/lnd/channels.js	Removed route for postTransactions.
backend/routes/lnd/payments.js	Added new route for sendPayment.
backend/utils/common.js	Updated readCookie method to accept a config parameter for SSO settings.
backend/utils/config.js	Modified environment variable handling and error messaging for node configuration.
docker/README.md	Added LN_IMPLEMENTATION variable to Docker setup instructions.
frontend/193.0e1a81316bbc29da.js	Introduced Angular components for currency conversion and transaction reporting.
frontend/193.b1206fbf24aa1327.js	Deleted obsolete currency converter component.
frontend/3rdpartylicenses.txt	Added detailed licensing information for various Angular packages.
frontend/index.html	Updated CSS and script references for improved styling and functionality.
frontend/polyfills.277648f7b3e820e3.js	Deleted deprecated polyfills file.
frontend/polyfills.2fc68655e9a361e8.js	Introduced new polyfills for Buffer and process objects.
frontend/runtime.738cba8440999ebd.js	Deleted obsolete runtime file.
frontend/runtime.8f43557e02af97f0.js	Introduced new module loading system.
package.json	Updated version from 0.15.2-beta to 0.15.3-beta.
server/controllers/cln/invoices.ts	Updated endpoint and response for deleteExpiredInvoice function.
server/controllers/cln/offers.ts	Modified URL endpoint casing in disableOffer function.
server/controllers/eclair/channels.ts	Simplified data structure in simplifyAllChannels and improved error handling.
server/controllers/lnd/channels.ts	Removed postTransactions function affecting payment processing logic.
server/controllers/lnd/payments.ts	Added sendPayment function for handling payment requests.
server/routes/lnd/channels.ts	Removed route for postTransactions.
server/routes/lnd/payments.ts	Added new route for sendPayment.
server/utils/common.ts	Updated readCookie method to accept a config parameter for SSO settings.
server/utils/config.ts	Modified environment variable handling and error messaging for node configuration.
src/app/cln/on-chain/on-chain-send-modal/on-chain-send-modal.component.html	Enhanced UI for fee rates display in the send modal.
src/app/cln/on-chain/on-chain-send-modal/on-chain-send-modal.component.ts	Added recommendedFee property and updated fee rates handling.
src/app/cln/peers-channels/channels/open-channel-modal/open-channel.component.html	Removed fee rate selection event binding.
src/app/cln/peers-channels/channels/open-channel-modal/open-channel.component.ts	Integrated fee rate fetching into onAdvancedPanelToggle.
src/app/cln/store/cln.effects.ts	Updated error handling and payload structure in effects.
src/app/eclair/on-chain/on-chain-send-modal/on-chain-send-modal.component.html	Enhanced UI for fee rates display in the send modal.
src/app/eclair/on-chain/on-chain-send-modal/on-chain-send-modal.component.ts	Added fee rates fetching and updated subscription management.
src/app/lnd/on-chain/on-chain-send-modal/on-chain-send-modal.component.html	Enhanced UI for fee rates display in the send modal.
src/app/lnd/on-chain/on-chain-send-modal/on-chain-send-modal.component.ts	Added fee rates fetching and updated subscription management.
src/app/lnd/on-chain/utxo-tables/utxos/utxos.component.html	Improved condition for "Bump Fee" option.
src/app/lnd/peers-channels/channels/channel-rebalance-modal/channel-rebalance.component.ts	Updated sendPayment method payload structure.
src/app/lnd/store/lnd.effects.ts	Streamlined payment parameter handling in sendPayment effect.
src/app/lnd/transactions/payments/lightning-payments.component.ts	Updated payment payload structure for dispatch.
src/app/lnd/transactions/send-payment-modal/send-payment.component.html	Adjusted tabindex attributes for improved focus order.
src/app/lnd/transactions/send-payment-modal/send-payment.component.spec.ts	Updated tests to reflect new payload structure.
src/app/lnd/transactions/send-payment-modal/send-payment.component.ts	Enhanced payment functionality with new properties and payload structure.
src/app/shared/components/data-modal/alert-message/alert-message.component.html	Improved layout and styling of alert message modal.
src/app/shared/models/lndModels.ts	Updated SendPayment interface properties for consistency.
src/app/shared/services/consts-enums-functions.ts	Added new constants and functions for fee limit calculations.
src/app/shared/theme/styles/theme-mode-dark.scss	Enhanced styling for dark theme components.
src/app/shared/theme/styles/theme-mode-light.scss	Added new styles for icons in light theme.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Frontend
    participant Backend

    User->>Frontend: Initiate Payment
    Frontend->>Backend: sendPayment(request)
    Backend->>Backend: Process Payment
    Backend-->>Frontend: Payment Status
    Frontend-->>User: Display Payment Result

Loading

Possibly related PRs

• Fix Unknown command error when disabling Bolt12 offers on CLN #1451: The changes in the main PR regarding the ESLint configuration for TypeScript files may relate to the modifications in the backend/controllers/cln/offers.js file, specifically the URL endpoint change in the disableOffer function, as both involve updates to the backend code structure and could be part of a broader effort to enhance code quality and maintainability in the application.

Poem

🐇 In the land of code, where changes bloom,
New features sprout, dispelling the gloom.
With payments sent and fees displayed,
Our app grows strong, no plans delayed.
So hop along, dear coder friends,
For in this PR, the magic never ends! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[saubyk]

tAck