Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add required indicate for "mappings" #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

7645re
Copy link

@7645re 7645re commented Jan 2, 2024

#137

I may be wrong, because I didn't use DNT much, but I think it can be done with little blood, if there are no such moments when we need "mappings" to be absent

we also probably need to add Require.Always for the Solution field if it is required for both switch-to-projects/switch-to-packages operations

We may not handle the error, but then it seems to me there will be a bunch of extra lines that are not needed to understand what the error is.

catch (JsonSerializationException e)
{
    throw new ArgumentException(e.Message);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant