-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add schedule #2
Conversation
…s from the setpoint AND mode is follow schedule
Thanks! Looks like this PR does not depend on watchforstock/evohome-client#117, right? It sets a label type="planned" when Evohome is preheating, and also when Evohome lowers the setpoint before the planned end of a heating period (precooling). prometheus_client keeps reporting the values for unique labels until they are removed. Should type="planned" be removed when planned == setpoint? Or should the planned temperature be output all the time, simply following the schedule and not only when planned != setpoint? Detecting/visualizing preheating+precooling can then be done in prometheus using a compare between planned and setpoint. |
Correct!
That was my intention :-)
|
I noticed that the permanent state is not reflected in the exporter results; investigating... |
Thanks! I also added a line to remove the planned temperature when the Honeywell servers are unavailable. |
Added schedule extraction & report planned temperature when it differs from the setpoint AND mode is follow schedule.