Merge pull request #63 from RevealBi/filterbinding-refactor

Refactored FilterBindings property
RevealBi · Sep 25, 2024 · 2d7fa8c · 2d7fa8c
2 parents ebcd4f1 + 4c02237
commit 2d7fa8c
Show file tree

Hide file tree

Showing 8 changed files with 282 additions and 288 deletions.
diff --git a/e2e/Sandbox/MainWindow.xaml.cs b/e2e/Sandbox/MainWindow.xaml.cs
@@ -46,8 +46,8 @@ public partial class MainWindow : Window
     {
         static readonly string _dashboardFilePath = Path.Combine(Environment.CurrentDirectory, "Dashboards");
 
-        readonly string _readFilePath = Path.Combine(_dashboardFilePath, DashboardFileNames.Sales);
-        //readonly string _readFilePath = Path.Combine(_dashboardFilePath, "My Dashboard.rdash");
+        //readonly string _readFilePath = Path.Combine(_dashboardFilePath, DashboardFileNames.Sales);
+        readonly string _readFilePath = Path.Combine(_dashboardFilePath, "New Dashboard.rdash");
 
         readonly string _saveJsonToPath = Path.Combine(_dashboardFilePath, "MyDashboard.json");
         readonly string _saveRdashToPath = Path.Combine(_dashboardFilePath, DashboardFileNames.MyDashboard);

diff --git a/src/Reveal.Sdk.Dom.Tests/Core/VisualizationCollectionFixture.cs b/src/Reveal.Sdk.Dom.Tests/Core/VisualizationCollectionFixture.cs
@@ -1,4 +1,6 @@
 using Reveal.Sdk.Dom.Core;
+using Reveal.Sdk.Dom.Data;
+using Reveal.Sdk.Dom.Filters;
 using Reveal.Sdk.Dom.Visualizations;
 using System.Collections.Generic;
 using Xunit;
@@ -108,6 +110,12 @@ private class MockVisualization : IVisualization, IParentDocument
             public string Description { get; set; }
             public IDataDefinition DataDefinition { get; }
             RdashDocument IParentDocument.Document { get; set; }
+            public List<Binding> FilterBindings { get; }
+
+            public DataSourceItem GetDataSourceItem()
+            {
+                throw new System.NotImplementedException();
+            }
         }
     }
 }