Fix building lr-mupen64plus-next on 32bit arm RPIOS Bookworm #4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the rpi5 on 32bit arm rpios bookworm, building failed with
/usr/lib/gcc/arm-linux-gnueabihf/12/include/arm_neon.h:18284:34: error: unknown type name ‘float16x4_t’; did you mean ‘bfloat16x4_t’?
18284 | vfmlal_low_f16 (float32x2_t __r, float16x4_t __a, float16x4_t __b)
| ^~~~~~~~~~~
| bfloat16x4_t
Add the option -mfp16-format=ieee which fixes this.
Use an array add_clags to handle the additional CFLAGS changes and use for the linkage_arm.S workaround.
joolswills
force-pushed
the
lr-mupen64plus-next_arm_on_aarch64
branch
from
53e7740
to
dd7d409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lr-mupen64plus-next - fix building on aarch64 kernel with arm userland
lr-mupen64plus-next - fix building on rpi5 on 32bit arm bookworm
On the rpi5 on 32bit arm rpios bookworm, building failed with
Add the option -mfp16-format=ieee which fixes this.
Use an array add_clags to handle the additional CFLAGS changes and use for the linkage_arm.S workaround.