Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change options for slider #79

Merged
merged 3 commits into from
Nov 25, 2024
Merged

change options for slider #79

merged 3 commits into from
Nov 25, 2024

Conversation

yibeichan
Copy link
Contributor

@yibeichan yibeichan commented Nov 22, 2024

  1. changed settings for slider (have to hardcode 0 to 100 for redcap, there is no explicit information about it in the data dictionary). a related PR for the UI is here improve slider reproschema-ui#355
  2. fix the missing "comma" error in choices like "0, 0=None (Not at all) | 1, 1=Slight (Rare, less than a day or two) | 2, 2=Mild (Several days) | 3, 3=Moderate (More than half the days) | 4, 4=Severe (Nearly every day)"

@yibeichan yibeichan requested a review from satra November 22, 2024 19:52
@yibeichan
Copy link
Contributor Author

  1. there is no direct information about minValue and maxValue being 0 and 100 in redcap dictionary, I have to hardcode it.
  2. fixed the error @Evan8456 found, passed the test

@yibeichan yibeichan merged commit e8aeb0d into ReproNim:main Nov 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant