[ENH] package with pyproject.tom and lint #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Remi-Gau
commented
Jun 18, 2024
•
Remi-Gau
commented
- package with pyproject.toml and hatchling: drop versioneer
- add isort / codespell config and to pre-commit
- add isort / codespell / flake8 to pre-commit config
- apply linting via pre-commit
- fix easy errors manually:
- unused imports
- f string related errors
- ...
- and silence others
- line length
- ...
|
Biggest chunk of line changes comes from dropping all the clutter that versioneer added in the repo and that can now be taken care of by hatchling and hatchling-VCS. |
Remi-Gau
commented
Jun 18, 2024
Remi-Gau
commented
Jun 18, 2024
Remi-Gau
commented
Jun 18, 2024
| docs/tools/ | ||
| reproschema/_version.py | ||
| max-line-length=79 | ||
| extend-ignore = B001, B006, B016, E501, E722, F821 |
There was a problem hiding this comment.
I can fix those errors but probably in a follow up PR.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.